Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announce (auto-refreshing) Official CVE Feed alpha #35608

Merged
merged 1 commit into from
Aug 25, 2022
Merged

Announce (auto-refreshing) Official CVE Feed alpha #35608

merged 1 commit into from
Aug 25, 2022

Conversation

PushkarJ
Copy link
Member

@PushkarJ PushkarJ commented Aug 1, 2022 •
edited
Loading

@k8s-ci-robot
Copy link
Contributor

@PushkarJ: You must be a member of the kubernetes/website-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Website milestone maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/hold
/sig security docs testing k8s-infra
/milestone v1.25
/area security blog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/blog Issues or PRs related to the Kubernetes Blog subproject labels Aug 1, 2022
@k8s-ci-robot
Copy link
Contributor

@PushkarJ: The label(s) area/security cannot be applied, because the repository doesn't have them.

In response to this:

/hold
/sig security docs testing k8s-infra
/milestone v1.25
/area security blog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 1, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Aug 1, 2022
@netlify
Copy link

netlify bot commented Aug 1, 2022 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 083a928
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6306a80ca63c1a0009c800b2
😎 Deploy Preview https://deploy-preview-35608--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sftim
sftim reviewed Aug 1, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some early feedback.

content/en/blog/_posts/2022-08-22-Auto-Refreshing-Official-CVE-Feed-is-now-in-alpha/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-08-22-Auto-Refreshing-Official-CVE-Feed-is-now-in-alpha/index.md Outdated Show resolved Hide resolved
This was referenced Aug 2, 2022
Merged
Open
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2022
@PushkarJ PushkarJ changed the base branch from main to dev-1.25 August 9, 2022 22:27
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2022
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language labels Aug 9, 2022
@PushkarJ PushkarJ changed the base branch from dev-1.25 to main August 9, 2022 22:34
@k8s-ci-robot k8s-ci-robot added language/fr Issues or PRs related to French language language/id Issues or PRs related to Indonesian language labels Aug 9, 2022
@PushkarJ PushkarJ mentioned this pull request Aug 23, 2022
Merged
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. language/zh Issues or PRs related to Chinese language and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2022
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 23, 2022
@PushkarJ
Copy link
Member Author

/hold for kubernetes/contributor-site#330

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2022
jberkus
jberkus suggested changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@jberkus jberkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor edits and suggestions.

content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2022-09-12-Announcing-the-Auto-Refreshing-Official-CVE-Feed/index.md Outdated Show resolved Hide resolved
@PushkarJ
[Feature Blog] Auto-refreshing Official CVE Feed - Alpha
083a928 
- Covers scope, goals, non-goals and personas
- Links to feature page and supporting contributor blog
@jberkus
Copy link
Contributor

jberkus commented Aug 24, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3fa975e1c59e62d0e4b91494de3ffef8cfc92940

@sftim
Copy link
Contributor

sftim commented Aug 25, 2022

To make this work, I suggest that I merge this as-is, and then add a commit to omit the link to the contributor blog. Once we manually release that article, we / I can revert the omission so that the link to the contributor blog reappears.

All of the above is to avoid publishing an announcement that includes a broken link, which of course is a poor UX.

@sftim
Copy link
Contributor

sftim commented Aug 25, 2022

/hold cancel
/approve

Thanks @PushkarJ

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 25, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nehaLohia27, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2022
@k8s-ci-robot k8s-ci-robot merged commit 962b6da into kubernetes:main Aug 25, 2022
@sftim
Copy link
Contributor

sftim commented Aug 25, 2022

/remove-language zh

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Aug 25, 2022
@sftim sftim mentioned this pull request Aug 25, 2022
Merged
@jberkus
Copy link
Contributor

jberkus commented Aug 25, 2022

Er, did we want to merge this? I thought we were publishing on 9/12? Or is the "future posts are visible" problem fixed?

@sftim
Copy link
Contributor

sftim commented Aug 25, 2022

The "future posts are visible" problem affects a different repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jberkus jberkus jberkus requested changes

@nehaLohia27 nehaLohia27 nehaLohia27 approved these changes

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@jberkus jberkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/security Categorizes an issue or PR as relevant to SIG Security. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@PushkarJ @k8s-ci-robot @mrbobbytables @jihoon-seo @ameukam @katcosgrove @sftim @jberkus @nehaLohia27